[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

[Ziqing Luo via Phabricator via cfe-commits]

ziqingluo-90 updated this revision to Diff 441816.
ziqingluo-90 added a comment.

I saw @aaron.ballman 's comment "//We typically don't add AST matchers until we have a need for them to be used in-tree (ASTMatchers.h is already really expensive to parse; adding matchers for everything possible with AST nodes would be prohibitively expensive).//" in this patch <https://reviews.llvm.org/D128103/new/>.   So I think the matchers for testing `noreturn` attributes is too specific to be in the `ASTMatcher.h`.  Moving them to where they are used.   While the `objcMessageCallee` is sort of the Obj-C counterpart of the `callee` matcher, so I think it is general enough to stay.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128314/new/

https://reviews.llvm.org/D128314

Files:
  clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp
  clang-tools-extra/test/clang-tidy/checkers/bugprone/infinite-loop-noreturn.mm
  clang/docs/LibASTMatchersReference.html
  clang/include/clang/ASTMatchers/ASTMatchers.h
  clang/lib/ASTMatchers/Dynamic/Registry.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128314.441816.patch
Type: text/x-patch
Size: 6636 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220701/f0d8c494/attachment-0001.bin>