[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker
Ziqing Luo via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 1 16:56:59 PDT 2022
ziqingluo-90 updated this revision to Diff 441816.
ziqingluo-90 added a comment.
I saw @aaron.ballman 's comment "//We typically don't add AST matchers until we have a need for them to be used in-tree (ASTMatchers.h is already really expensive to parse; adding matchers for everything possible with AST nodes would be prohibitively expensive).//" in this patch <https://reviews.llvm.org/D128103/new/>. So I think the matchers for testing `noreturn` attributes is too specific to be in the `ASTMatcher.h`. Moving them to where they are used. While the `objcMessageCallee` is sort of the Obj-C counterpart of the `callee` matcher, so I think it is general enough to stay.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 6636 bytes
Desc: not available
More information about the cfe-commits