[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

Nikita Popov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 1 14:20:37 PDT 2022


nikic added inline comments.


================
Comment at: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp:654
+  // summary for aliasee will not be emitted.
+  if (Aliasee->getValueID() != Value::ValueTy::GlobalIFuncVal) {
+    bool NonRenamableLocal = isNonRenamableLocal(A);
----------------
MaskRay wrote:
> Use an early return to avoid indenting so many lines.
Also, please use `isa<GlobalIFunc>(Aliasee)` instead of inspecting the value ID.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129009/new/

https://reviews.llvm.org/D129009



More information about the cfe-commits mailing list