[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

Cole Kissane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 1 11:25:12 PDT 2022


ckissane added inline comments.


================
Comment at: llvm/lib/ProfileData/InstrProf.cpp:154
+    OS << ("profile uses " + compression::profile::AlgorithmName +
+           " compression but the profile reader was built " + "without " +
+           compression::profile::AlgorithmName + " support");
----------------
MaskRay wrote:
> leonardchan wrote:
> > `" compression but the profile reader was built " + "without "` -> `" compression but the profile reader was built without "`
> Keep the diagnostic unchanged in this patch.
And the other similar changes?
I will note these are NFC because if zlib is being used (as it currently always is), it has the exact same output.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128953/new/

https://reviews.llvm.org/D128953



More information about the cfe-commits mailing list