[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:4859
             << Function;
+      } else if (!Recursive) {
+        Function->setInstantiationIsPending(true);
----------------
This condition seems a little aggressive, and will end up instantiating way more than just constexprs here, right?  I guess my real question is what it is about the constexpr that makes us decide to skip the instantiation earlier.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128119/new/

https://reviews.llvm.org/D128119