[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

[Chuanqi Xu via Phabricator via cfe-commits]

ChuanqiXu added a comment.

In D126189#3617896 <https://reviews.llvm.org/D126189#3617896>, @iains wrote:

> In D126189#3617850 <https://reviews.llvm.org/D126189#3617850>, @ChuanqiXu wrote:
>
>> @iains may I ask what's the issue to not land this? It looks like you're waiting for the behavior to be consistency with GCC?
>>
>> Since this patch could fix https://github.com/llvm/llvm-project/issues/51873, which breaks the users to compile a hello world example.
>
> I need to make some typo corrections; there is no issue (I'm not waiting for anything) just prioritising posting patches to complete C++20 support .. will land this soon.

Thanks! The reason why I am a little bit hurry is that I'm trying to implement std modules: https://github.com/ChuanqiXu9/stdmodules

Now it runs good for libcxx. But it would meet segfault in https://github.com/ChuanqiXu9/stdmodules/blob/master/test/HelloWorld/HelloWorld.cpp if we don't land this revision.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126189/new/

https://reviews.llvm.org/D126189