[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Thu Jun 30 12:08:54 PDT 2022

erichkeane added a comment.

In D126907#3623120 <https://reviews.llvm.org/D126907#3623120>, @JDevlieghere wrote:

> This change triggers an assertion when building an LLDB test case:
>
>   UNREACHABLE executed at /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/lib/Sema/SemaTemplate.cpp:1726!
>   Assertion failed: (InstantiatingSpecializations.empty() && "failed to clean up an InstantiatingTemplate?"), function ~Sema, file /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/lib/Sema/Sema.cpp, line 458.
>   PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
>   Stack dump:
>   0.	Program arguments: /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/clang -fmodules -gmodules -fmodules-cache-path=/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/module-cache-clang/lldb-api -gmodules -fcxx-modules -std=c++11 -g -O0 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -arch x86_64 -I/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/make/../../../../../include -I/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/span -I/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/make -include /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/make/test_common.h -fno-limit-debug-info -fmodules -gmodules -fmodules-cache-path=/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/module-cache-clang/lldb-api -gmodules -fcxx-modules -DLLDB_USING_LIBCPP -stdlib=libc++ -std=c++20 --driver-mode=g++ -MT main.o -MD -MP -MF main.d -c -o main.o /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/span/main.cpp
>   1.	/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/span/main.cpp:1:2: current parser token 'include'
>   Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
>   0  clang                    0x0000000106bc157e llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 46
>   1  clang                    0x0000000106bc0258 llvm::sys::RunSignalHandlers() + 248
>   2  clang                    0x0000000106bc0962 llvm::sys::CleanupOnSignal(unsigned long) + 210
>   3  clang                    0x0000000106adb82a (anonymous namespace)::CrashRecoveryContextImpl::HandleCrash(int, unsigned long) + 106
>   4  clang                    0x0000000106adba2e CrashRecoverySignalHandler(int) + 110
>   5  libsystem_platform.dylib 0x00007fff67b405fd _sigtramp + 29
>   6  libsystem_platform.dylib 0x00007ffeeab5b460 _sigtramp + 18446744071612509824
>   7  libsystem_c.dylib        0x00007fff67a12808 abort + 120
>   8  libsystem_c.dylib        0x00007fff67a11ac6 err + 0
>   9  clang                    0x0000000108a1325c clang::Sema::~Sema() + 5660
>   10 clang                    0x0000000107698e41 clang::CompilerInstance::~CompilerInstance() + 625
>   11 clang                    0x00000001076a7fe5 compileModuleImpl(clang::CompilerInstance&, clang::SourceLocation, llvm::StringRef, clang::FrontendInputFile, llvm::StringRef, llvm::StringRef, llvm::function_ref<void (clang::CompilerInstance&)>, llvm::function_ref<void (clang::CompilerInstance&)>) + 4517
>   12 clang                    0x00000001076a9b16 compileModuleAndReadASTImpl(clang::CompilerInstance&, clang::SourceLocation, clang::SourceLocation, clang::Module*, llvm::StringRef) + 1238
>   13 clang                    0x00000001076a370b compileModuleAndReadAST(clang::CompilerInstance&, clang::SourceLocation, clang::SourceLocation, clang::Module*, llvm::StringRef) + 1947
>   14 clang                    0x00000001076a2b97 clang::CompilerInstance::findOrCompileModuleAndReadAST(llvm::StringRef, clang::SourceLocation, clang::SourceLocation, bool) + 3783
>   15 clang                    0x00000001076a3aa7 clang::CompilerInstance::loadModule(clang::SourceLocation, llvm::ArrayRef<std::__1::pair<clang::IdentifierInfo*, clang::SourceLocation>>, clang::Module::NameVisibilityKind, bool) + 695
>   16 clang                    0x0000000109b8a630 clang::Preprocessor::HandleHeaderIncludeOrImport(clang::SourceLocation, clang::Token&, clang::Token&, clang::SourceLocation, clang::detail::SearchDirIteratorImpl<true>, clang::FileEntry const*) + 7792
>   17 clang                    0x0000000109b822e1 clang::Preprocessor::HandleIncludeDirective(clang::SourceLocation, clang::Token&, clang::detail::SearchDirIteratorImpl<true>, clang::FileEntry const*) + 177
>   18 clang                    0x0000000109b82f8c clang::Preprocessor::HandleDirective(clang::Token&) + 2604
>   19 clang                    0x0000000109b50877 clang::Lexer::LexTokenInternal(clang::Token&, bool) + 6199
>   20 clang                    0x0000000109b4cf15 clang::Lexer::Lex(clang::Token&) + 133
>   21 clang                    0x0000000109bc4889 clang::Preprocessor::Lex(clang::Token&) + 89
>   22 clang                    0x000000010899438a clang::Parser::Initialize() + 5018
>   23 clang                    0x00000001088b9759 clang::ParseAST(clang::Sema&, bool, bool) + 441
>   24 clang                    0x000000010772aac3 clang::FrontendAction::Execute() + 99
>   25 clang                    0x000000010769fb6f clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) + 863
>   26 clang                    0x00000001077b6493 clang::ExecuteCompilerInvocation(clang::CompilerInstance*) + 707
>   27 clang                    0x00000001050aa241 cc1_main(llvm::ArrayRef<char const*>, char const*, void*) + 2065
>   28 clang                    0x00000001050a56ad ExecuteCC1Tool(llvm::SmallVectorImpl<char const*>&) + 285
>   29 clang                    0x00000001074b2227 void llvm::function_ref<void ()>::callback_fn<clang::driver::CC1Command::Execute(llvm::ArrayRef<llvm::Optional<llvm::StringRef>>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>*, bool*) const::$_4>(long) + 23
>   30 clang                    0x0000000106adb73c llvm::CrashRecoveryContext::RunSafely(llvm::function_ref<void ()>) + 236
>   31 clang                    0x00000001074b1c95 clang::driver::CC1Command::Execute(llvm::ArrayRef<llvm::Optional<llvm::StringRef>>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>*, bool*) const + 293
>   32 clang                    0x0000000107474af7 clang::driver::Compilation::ExecuteCommand(clang::driver::Command const&, clang::driver::Command const*&, bool) const + 1111
>   33 clang                    0x0000000107474de0 clang::driver::Compilation::ExecuteJobs(clang::driver::JobList const&, llvm::SmallVectorImpl<std::__1::pair<int, clang::driver::Command const*>>&, bool) const + 144
>   34 clang                    0x000000010749285f clang::driver::Driver::ExecuteCompilation(clang::driver::Compilation&, llvm::SmallVectorImpl<std::__1::pair<int, clang::driver::Command const*>>&) + 911
>   35 clang                    0x00000001050a4d1b clang_main(int, char**) + 10315
>   36 libdyld.dylib            0x00007fff67943cc9 start + 1
>   37 libdyld.dylib            0x0000000000000026 start + 18446603338778395486
>
> https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/44981/testReport/junit/lldb-api/functionalities_data-formatter_data-formatter-stl_libcxx_span/TestDataFormatterLibcxxSpan_py/

Yikes!  Thanks for the revert.  I didn't see the email from the bot until just about 2 minutes before you reverted.  I'll see if I can reproduce.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126907/new/

https://reviews.llvm.org/D126907