[PATCH] D128844: Improve the formatting of static_assert messages
Mark de Wever via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 30 10:13:06 PDT 2022
Mordante accepted this revision.
Mordante added a comment.
In D128844#3622220 <https://reviews.llvm.org/D128844#3622220>, @aaron.ballman wrote:
> So I *think* this LG, but am not certain what will happen when you land it. I think the precommit CI failures are not failures that will happen when testing against the just-built clang.
Most Linux runner use the apt.llvm.org nightly builds and are updated on an irregular interval. The Bootstrapping build will use the just-built Clang. So when the CI is green all should be fine.
I wanted to suggest a regex, but I see the latest patch already does that.
Thanks for improving the readability of the diagnostics! LGTM when the CI passes.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits