[PATCH] D128844: Improve the formatting of static_assert messages

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

I agree with the changes in principle, but it looks like the libc++ precommit CI builder is failing with a bunch of failures... but those failures look like the precommit CI isn't testing the Clang built by the patch?

  error: 'error' diagnostics expected but not seen:
    File * Line * (directive at /home/libcxx-builder/.buildkite-agent/builds/5d14e636cf69-1/llvm-project/libcxx-ci/libcxx/test/std/numerics/rand/rand.eng/rand.eng.lcong/params.fail.cpp:22): static_assert failed due to requirement '1ULL == 0 || 1ULL < 1ULL': linear_congruential_engine invalid parameters
    File * Line * (directive at /home/libcxx-builder/.buildkite-agent/builds/5d14e636cf69-1/llvm-project/libcxx-ci/libcxx/test/std/numerics/rand/rand.eng/rand.eng.lcong/params.fail.cpp:24): static_assert failed due to requirement '1ULL == 0 || 1ULL < 1ULL': linear_congruential_engine invalid parameters
    File * Line * (directive at /home/libcxx-builder/.buildkite-agent/builds/5d14e636cf69-1/llvm-project/libcxx-ci/libcxx/test/std/numerics/rand/rand.eng/rand.eng.lcong/params.fail.cpp:27): static_assert failed due to requirement 'is_unsigned<int>::value': _UIntType must be unsigned type
  error: 'error' diagnostics seen but not expected:
    Line 218: static_assert failed due to requirement '1ULL == 0 || 1ULL < 1ULL' "linear_congruential_engine invalid parameters"
    Line 217: static_assert failed due to requirement '1ULL == 0 || 1ULL < 1ULL' "linear_congruential_engine invalid parameters"
    Line 219: static_assert failed due to requirement 'is_unsigned<int>::value' "_UIntType must be unsigned type"
  6 errors generated.

So I *think* this LG, but am not certain what will happen when you land it. I think the precommit CI failures are not failures that will happen when testing against the just-built clang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128844/new/

https://reviews.llvm.org/D128844