[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 30 05:42:15 PDT 2022

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Basically LGTM -- can you also add a release note about the assertion fix?

Comment at: clang/test/SemaCXX/constexpr-array-init.cpp:1
+// RUN: %clang_cc1 -std=c++20 -verify %s
Can remove spurious newline

Comment at: clang/test/SemaCXX/constexpr-array-init.cpp:15
+static constexpr Foo bar[2][1] = { // expected-error {{constexpr variable 'bar' must be initialized by a constant expression}} \
Same here.

Also, I'd appreciate a FIXME comment about what this is testing (it's not obvious from the context) and that this code is expected to compile without a diagnostic in the future (so it's a bit more obviously correct when we do fix that).



More information about the cfe-commits mailing list