[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:199
         UsesAllocatorsDecls;
+    /// Data is needed on creating capture fields for implicit
+    /// defualt first|private clause.
----------------
Data required?


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:200
+    /// Data is needed on creating capture fields for implicit
+    /// defualt first|private clause.
+    struct ImplicitDefaultFDInfoTy {
----------------
default


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:212
+    };
+    /// List of captuer fields
+    llvm::SmallVector<ImplicitDefaultFDInfoTy, 8>
----------------
Captured?


================
Comment at: clang/lib/Sema/TreeTransform.h:122
+  /// the RebuildME uses to set if member expression needs to be rebuilt.
+  bool RebuildME = false;
+
----------------
I think we don't need to add a new field here. Can instead we have a check for regions with default clauses, if possible?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127803/new/

https://reviews.llvm.org/D127803