[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

Phoebe Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 29 18:42:35 PDT 2022


pengfei added a comment.

In D128571#3619438 <https://reviews.llvm.org/D128571#3619438>, @pengfei wrote:

> In D128571#3619265 <https://reviews.llvm.org/D128571#3619265>, @alexfh wrote:
>
>> @pengfei could you fix the Darwin tests as well? And a general comment regarding the ongoing `_Float16` effort: I think that this change should have been a part of https://reviews.llvm.org/D107082 to make it possible to build a consistently working toolchain. Thus, if this commit can't be landed in a reasonable time, I'd suggest reverting https://reviews.llvm.org/D107082.
>
> @alexfh I'm working on that. I'm asking suggestion on solving it in a better way, but at least we can disable the test for Darwin (maybe just for stage1 if possible) since it's expected due to the ABI change.

Disabled these tests for Darwin. I'll reland the patch in one day if no objections.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128571/new/

https://reviews.llvm.org/D128571



More information about the cfe-commits mailing list