[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

Please note that documentation and test locations were changed recently. Please rebase from `main` and make necessary changes.



================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/SymmetricBinaryOperatorCheck.h:27
+public:
+  SymmetricBinaryOperatorCheck(StringRef Name, ClangTidyContext *Context);
+};
----------------
Please add `isLanguageVersionSupported`.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:135
 
+- New :doc:`cppcoreguidelines-symmetric-binary-operator
+  <clang-tidy/checks/cppcoreguidelines-symmetric-binary-operator>` check.
----------------
Please keep alphabetic order of entries.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:138
+
+  Finds operators that are symmetric with respect to the type of their
+  parameters and warns that these operators should be friend or free functions.
----------------
One sentence should be enough.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-symmetric-binary-operator.rst:6
+
+This check flags all member operators that are symmetric, i.e. operators where
+both sides of the operator are of the same type and are not compound
----------------
Please make first sentence same as in Release Notes.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-symmetric-binary-operator.rst:10
+
+The check is based on `C++ Core Guidelines C.161 <https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c161-use-non-member-functions-for-symmetric-operators>`
+
----------------
This should be at end of documentation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128861/new/

https://reviews.llvm.org/D128861