[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

[Eli Friedman via Phabricator via cfe-commits]

efriedma added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenTBAA.cpp:366
+      // so may differ from declaration order. In particular, Itanium ABI will
+      // allocate a primary base first.
+      llvm::sort(Fields,
----------------
Maybe add a comment explaining why each TBAAStructField has a unique offset.  (If the offsets aren't unique, you need to use stable_sort.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126956/new/

https://reviews.llvm.org/D126956