[PATCH] D128352: [clang][dataflow] Use diagnosis API in optional checker

[Sam Estep via Phabricator via cfe-commits]

samestep marked an inline comment as done.
samestep added inline comments.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:126-129
+        auto *Lattice =
+            llvm::any_cast<typename AnalysisT::Lattice>(&State.Lattice.Value);
+        PostVisitStmt(Stmt, DataflowAnalysisState<typename AnalysisT::Lattice>{
+                                *Lattice, State.Env});
----------------
sgatev wrote:
> 
I tried this but it doesn't seem to work; I get this error:

```
llvm-project/clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:130:13: error: non-const lvalue reference to type 'clang::dataflow::SourceLocationsLattice' cannot bind to a temporary of type 'clang::dataflow::SourceLocationsLattice'
      auto &Lattice =
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128352/new/

https://reviews.llvm.org/D128352