[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

Valentin Clement via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 29 11:55:20 PDT 2022


clementval added inline comments.


================
Comment at: mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp:215
+LogicalResult DistributeOp::verify(){
+  if (this->lowerBound().empty()) {
+    return emitOpError() << "empty lowerbound for distribute loop operation";
----------------
No brace - https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements


================
Comment at: mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp:219
+  
+  if (this->upperBound().empty()) {
+    return emitOpError() << "empty upperbound for distribute loop operation";
----------------
no brace


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105584/new/

https://reviews.llvm.org/D105584



More information about the cfe-commits mailing list