[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

[Abid via Phabricator via cfe-commits]

abidmalikwaterloo added a comment.

In D105584#3618040 <https://reviews.llvm.org/D105584#3618040>, @abidmalikwaterloo wrote:

> In D105584#3617666 <https://reviews.llvm.org/D105584#3617666>, @clementval wrote:
>
>> In D105584#3617456 <https://reviews.llvm.org/D105584#3617456>, @abidmalikwaterloo wrote:
>>
>>>   // CHECK-LABEL: omp_DistributeOp
>>>   func.func @omp_DistributeOp(%lb : index, %ub : index, %step : index, %data_var : memref<i32>, %chunk_var : i32) -> () {
>>>      // CHECK: omp.DistributeOp collapse(2)
>>>     "omp.DistributeOp" (%lb, %ub, %step) ({
>>>       ^bb0(%iv: index):
>>>        omp.yield
>>>     }) {operand_segment_sizes = dense<[1,1,1,0,0]> : vector<5xi32>, collapse_val = 2} :
>>>       (index, index, index) -> ()
>>>    
>>>    return
>>>    }
>>>
>>> Is this a valid test case for the operation?
>>
>> Should it be `"omp.distribute" (%lb, %ub, %step) ({`?
>
> Yes. It should be. The rest should be okay? But, the test is failing.

It is working. I will load the patch.  Thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105584/new/

https://reviews.llvm.org/D105584