[PATCH] D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext

[serge via Phabricator via cfe-commits]

serge-sans-paille added a comment.

@aaron.ballman  : I agree with most of your suggestion except the one below that I annotated accordingly

  struct Base {
    virtual void O0();
  
  private:
    void II();
  };
  
  struct Derived : Base {
    void OO(); // We should warn about this
    void I1();   // I think we should warn about this too, because implementation of, say, `O0` could refer to `I1` wich would be confusable with `Il`
  };
  
  void I1(); // we should probably warn here too, becaus ein the implementation of, says, `O0`, if we refer to `Il`, it's confusable with this `I1` too


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128715/new/

https://reviews.llvm.org/D128715