[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

Wed Jun 29 10:15:47 PDT 2022

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Thank you for the fix, the changes LGTM! From our off-review discussion, I understand you need me to commit this on your behalf. What name and email address would you like me to use for patch attribution? I did have a suggestion on changing the release notes slightly, but I can do that for you when I land the changes, so don't feel obligated to push up a new patch unless you'd like to.

================
Comment at: clang/docs/ReleaseNotes.rst:278-281
+- The ``-Winfinite-recursion`` diagnostic will not warn for
+  unevaluated operands of ``typeid`` expression. Unevaluated
+  operands of ``typeid`` expression are skipped for the CFG build.
+  This fixes `Issue 21668 <https://github.com/llvm/llvm-project/issues/21668>`_.
----------------
Reworded a bit.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128747/new/

https://reviews.llvm.org/D128747