[PATCH] D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`

Richard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 29 08:23:59 PDT 2022


LegalizeAdulthood added a comment.

This whole check seems weird to me.  I mean, almost every use of a standard container could throw `std::bad_alloc` but we don't insist on a local `catch` for `bad_alloc` at every possible throwing call site.

Why would we assume that every call site of `stoi` or `stod` **must** have an exception handler immediately around it?  It's perfectly acceptable for an application to handle this at an outer scope that can't be detected by clang-tidy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128697/new/

https://reviews.llvm.org/D128697



More information about the cfe-commits mailing list