[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files
Tobias Hieta via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 29 07:57:34 PDT 2022
thieta added inline comments.
================
Comment at: clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp:136
+ FileManager fm(CI.getFileSystemOpts());
+ SmallString<128> absPath(astPath);
+ fm.makeAbsolutePath(absPath);
----------------
thieta wrote:
> Pretty sure 128 is wrong here - but I searched the codebase and that seems to be the most common size used? I couldn't find anything using PATH_MAX or something like that.
Never mind 128 is just the default size not the absolute size. Got it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128704/new/
https://reviews.llvm.org/D128704
More information about the cfe-commits
mailing list