[PATCH] D128826: Go-to-type on smart_ptr<Foo> now also shows Foo

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 29 07:47:15 PDT 2022

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.

Comment at: clang-tools-extra/clangd/HeuristicResolver.h:75
+  // could look up the name appearing on the RHS.
+  const Type *getPointeeType(const Type *T) const;
tom-anders wrote:
> Not sure if it's the right call to make this public? The documentation needs to be adapted at least I think
It's a bit unfortunate that it doesn't fit the usual pattern of "resolve the target of this AST node", but it's fairly closely related, it needs to use the Ctx in the same way, and it's already implemented here... I think it's OK (at least I can't see a better alternative).

We should probably have a unit test for it though.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list