[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

Nemanja Ivanovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 29 01:04:59 PDT 2022


nemanjai added a comment.

I am ok with this change overall, I just have a couple of questions about naming of the option.

1. Is there any precedent for options that start with `-maix` or `-m<OS>` for any other OS?
2. Is `quadword` the best word to use? There is no type information and this is restricted to integers. Would something like `-maix-i128-atomics` be a better name?
3. Since this is kind of an ABI-related decision, would it make sense (and would it be possible) to make this a further suboption to the `-mabi` option? Something like `-mabi=vec-extabi,i128-atomics,ieeelongdouble`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127189/new/

https://reviews.llvm.org/D127189



More information about the cfe-commits mailing list