[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Jeff Niu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 28 21:41:44 PDT 2022


Mogball added inline comments.


================
Comment at: mlir/lib/Transforms/Utils/CommutativityUtils.cpp:178
+using UniquePtrOperandBFS = std::unique_ptr<OperandBFS>;
+using ArrayRefOperandBFS = ArrayRef<UniquePtrOperandBFS>;
+
----------------
Please remove these. They don't improve readability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124750/new/

https://reviews.llvm.org/D124750



More information about the cfe-commits mailing list