[PATCH] D128754: Refactor LLVM compression namespaces

Cole Kissane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 28 19:40:14 PDT 2022

ckissane marked an inline comment as done.
ckissane added inline comments.

Comment at: clang-tools-extra/clangd/index/Serialization.cpp:242
+    return error(
+        "Compressed string table, but compression::serialize is unavailable");
leonardchan wrote:
> nit: Could we add some function that returns a string of whatever compression is used? This way we have a more descriptive error message showing what specifically is unavailable. Same comment elsewhere there's logging/error reporting but the string is "compression::serialize".
sure, I can add a AlgorithmName property to the zlib namespace and future compression namespaces, then we can print out compression::serialize::AlgorithmName to see what is being used



More information about the cfe-commits mailing list