[PATCH] D108469: Improve handling of static assert messages.

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 28 16:16:40 PDT 2022


cor3ntin updated this revision to Diff 440804.
cor3ntin added a comment.

- Undo the change of diagnostic message formatting as they break

libc++ tests
so we will keep printing <static_assert failed "message"> instead
<of static_assert failed: message>

Changing the format should be done -if at all- in a separate 
change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108469/new/

https://reviews.llvm.org/D108469

Files:
  clang/docs/ReleaseNotes.rst
  clang/lib/Basic/Diagnostic.cpp
  clang/lib/Sema/SemaDeclCXX.cpp
  clang/lib/StaticAnalyzer/Checkers/PaddingChecker.cpp
  clang/test/Lexer/null-character-in-literal.c
  clang/test/Misc/diag-special-chars.c
  clang/test/Misc/wrong-encoding.c
  clang/test/SemaCXX/static-assert.cpp
  llvm/include/llvm/Support/Unicode.h
  llvm/lib/Support/Unicode.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108469.440804.patch
Type: text/x-patch
Size: 38692 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220628/703e2fd0/attachment-0001.bin>


More information about the cfe-commits mailing list