[PATCH] D128752: [CUDA] Stop adding CUDA features twice

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 28 13:22:23 PDT 2022


jhuber6 added a comment.

In D128752#3616675 <https://reviews.llvm.org/D128752#3616675>, @tra wrote:

> We already heard complaints that searching for CUDA installation in multiple places does add a measurable delay when the search hits NFS-mounted directories.
>
> Replacing uses of `CudaInstallation` with a getter function returning a reference to a singleton would be great.

Sounds good, I'll make a patch for it. Considering that this one doesn't change that this one doesn't change anything we don't already do on that front is it good to land separately?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128752/new/

https://reviews.llvm.org/D128752



More information about the cfe-commits mailing list