[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums
Jolanta Jensen via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 28 09:16:54 PDT 2022
jolanta.jensen added inline comments.
Comment at: clang/include/clang/Basic/TargetInfo.h:225-226
unsigned HasAlignMac68kSupport : 1;
- unsigned RealTypeUsesObjCFPRetMask : (int)FloatModeKind::Last + 1;
+ unsigned RealTypeUsesObjCFPRetMask
+ : (int)FloatModeKind::LLVM_BITMASK_LARGEST_ENUMERATOR;
unsigned ComplexLongDoubleUsesFP2Ret : 1;
> Whoops, I missed this (thanks @shafik for asking me about it in private)!
> I believe the original code was setting the field width to be `1 << 5` bits wide instead of specifying it as being 6 bits wide.
Oh dear, I was to replace log2 with bitWidth and I only did half the job. Thanks for spotting!
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits