[PATCH] D128319: Survive #pragma once from virtual file.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 28 08:55:26 PDT 2022


aaron.ballman added a comment.

In D128319#3615779 <https://reviews.llvm.org/D128319#3615779>, @v.g.vassilev wrote:

> Historically, the patch was developed before the extended support of virtual files in Clang. Given that this is very hard to test and it looks like this is not needed on our end anymore. I'd propose to pause this for now.

That'd be fine by me -- I'd recommend explicitly abandoning the revision in Phabricator if you don't intend to work on it (that gets it off everyone's review plate).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128319/new/

https://reviews.llvm.org/D128319



More information about the cfe-commits mailing list