[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.
Martin Böhme via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 27 23:48:40 PDT 2022
mboehme marked 2 inline comments as done.
mboehme added inline comments.
Comment at: clang/test/SemaCXX/attr-declspec-ignored.cpp:3-6
+// For this test, we want the contents of the namespaces to be indented, which
+// clang-format doesn't like. Also, clang-format reformats the long lines in a
+// way that's difficult to read.
+// clang-format off
> We don't typically put clang-format markings into tests -- we don't require that tests be formatted, and it's a bug that precommit CI continues to fail because of it (https://github.com/llvm/llvm-project/issues/55982).
> Feel free to remove this bit when landing.
Got it. Done!
I've also commented on the bug.
Comment at: clang/test/SemaCXX/attr-declspec-ignored.cpp:62
+// clang-format on
> Same here for this one.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits