[PATCH] D108469: Improve handling of static assert messages.

[Corentin Jabot via Phabricator via cfe-commits]

cor3ntin added inline comments.


================
Comment at: clang/lib/Basic/Diagnostic.cpp:837
+          llvm::sys::unicode::isFormatting(CodepointValue)) {
+        OutStr.append(CodepointBegin, CodepointEnd);
+        continue;
----------------
cor3ntin wrote:
> erichkeane wrote:
> > What about...?
> I doesn't seem much better but sure, I can do that
actually, you would need something like
`OutStream.write(reinterpret_cast<const char*>(CodepointBegin), std::distance(CodepointBegin, CodepointEnd));`

Unless you insist, I'd rather not change it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108469/new/

https://reviews.llvm.org/D108469