[PATCH] D128667: [WIP] Add Zstd ELF support

Cole Kissane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 27 12:35:02 PDT 2022


ckissane added a comment.

In D128667#3613222 <https://reviews.llvm.org/D128667#3613222>, @MaskRay wrote:

> `llvm-objcopy --decompress-debug-sections clang.zstd clang.zstd.uncompress` doesn't work.
>
>   % /tmp/out/custom1/bin/llvm-objcopy --decompress-debug-sections clang.zstd clang.zstd.uncompress
>   /tmp/out/custom1/bin/llvm-objcopy: error: 'clang.zstd': '.debug_loc': zlib error: Z_DATA_ERROR
>
> Add a new test `llvm/test/tools/llvm-objcopy/compress-debug-sections-zstd.test` and check existing tests for zlib (SHF_COMPRESSED).
> I'll create a patch to remove .zdebug support to simplify the code.
>
> Tip: you can nullify a compression/uncompression place, then run `ninja check-llvm` to find all places in llvm/ where a test may be relevant.

it seems that --decompress-debug-sections assumes always Z type compression. I can update the patch to fix this


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128667/new/

https://reviews.llvm.org/D128667



More information about the cfe-commits mailing list