[PATCH] D128465: Zstandard as a second compression method to LLVM

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 27 11:22:30 PDT 2022

MaskRay added a comment.

In D128465#3612948 <https://reviews.llvm.org/D128465#3612948>, @phosek wrote:

> I think this patch should be broken into at least two:
> 1. Refactor `llvm/include/llvm/Support/Compression.h` and `llvm/lib/Support/Compression.cpp` to introduce a generic interface and use it throughout the codebase.
> 2. zstd support in `llvm/include/llvm/Support/Compression.h` including the CMake bits.
> When uploading future changes, please also make sure to include full context.

Agree. As soon as the namespace refactoring is in a good enough shape, I think you may land the refactoring part before the rest of zstd patches.

Note: if you have a deep stacked patches, it may be useful to have a branch somewhere (e.g. your llvm-project fork on Github) so that interested folks can get the whole picture more easily.
(`arc patch Dxxxxx` can technically apply a deep stack, but it often fails to apply changes cleanly.)



More information about the cfe-commits mailing list