[PATCH] D128667: [WIP] Add Zstd ELF support

Cole Kissane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 27 11:14:24 PDT 2022

ckissane added a comment.

In D128667#3612956 <https://reviews.llvm.org/D128667#3612956>, @MaskRay wrote:

> The lld/ change should be separate. And it needs tests. We should have several tests such as mixed zlib and zstd input, malformed zstd input, compressed level, etc. `OutputSections` should not have a new member.

Got it, I have also removed the extra member.

In D128667#3612956 <https://reviews.llvm.org/D128667#3612956>, @MaskRay wrote:

> The parallel output part will be tricky, too (see D117853 <https://reviews.llvm.org/D117853>). I can handle the lld/ELF part and leave other stuff to you.

Sounds good, and thank you for your offer to help!

In D128667#3612956 <https://reviews.llvm.org/D128667#3612956>, @MaskRay wrote:

> llvm-objcopy should probably be a separate patch as well.

got it.

> - clang (Driver, cc1as) and MC (including `llvm-mc --compress-debug-sections`) in one patch
> - lld/ELF
> - llvm-objcopy
>> Context not available.
> See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface "To make reviews easier, please always include as much context as possible with your diff!"

Doing so now



More information about the cfe-commits mailing list