[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

[Min-Yih Hsu via Phabricator via cfe-commits]

myhsu added a comment.

> I pushed this change, but for some reason phabricator doesn't show it and close the review... I wonder if it's because I rebased it?

You forgot to add <https://github.com/llvm/llvm-project/commit/b2cb7e81f8978ccce5c5e7b316480b88785ca9cc> "Differential Revison: https://reviews.llvm.org/DXXXXXX", which is how Phabricator identifies the differential to close. I don't think it has anything to do with rebasing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128157/new/

https://reviews.llvm.org/D128157