[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`
Andrzej Warzynski via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 27 09:50:23 PDT 2022
awarzynski added inline comments.
================
Comment at: clang/lib/Driver/ToolChain.cpp:185
{"flang", "--driver-mode=flang"},
+ {"flang-new", "--driver-mode=flang"},
{"clang-dxc", "--driver-mode=dxc"},
----------------
clementval wrote:
> Why do we need two lines here? Shouldn't we have a single line with the name chosen by the cmake option?
That would require making this file "configurable" by CMake. That would be quite an intrusive design change, which IMO we should avoid.
Unless there's some easy way that I'm missing here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125788/new/
https://reviews.llvm.org/D125788
More information about the cfe-commits
mailing list