[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

Bardia Mahjour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 27 09:43:54 PDT 2022


bmahjour added a comment.

The description should explain why this change is necessary.



================
Comment at: clang/test/CodeGen/lower-mass-end-to-end.c:1
+// RUN: %clang -mllvm -enable-ppc-gen-scalar-mass -O3 -fapprox-func --target=powerpc64le-unknown-linux-gnu -S %s -o -| FileCheck %s -check-prefix=CHECK-AFN
+// RUN: %clang -mllvm -enable-ppc-gen-scalar-mass -Ofast --target=powerpc64le-unknown-linux-gnu -S %s -o -| FileCheck %s -check-prefix=CHECK-FAST
----------------
Please add negative end-to-end tests as well (eg. when `-enable-ppc-gen-scalar-mass` is false or when `-fno-approx-func`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128653/new/

https://reviews.llvm.org/D128653



More information about the cfe-commits mailing list