[PATCH] D108469: Improve handling of static assert messages.

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: llvm/lib/Support/Unicode.cpp:268
+  // hyphen in most terminals.
+  return Printables.contains(UCS) || UCS == 0x00AD;
+}
----------------
As a nit, this condition might be worth reversing to get the 'fast thing' on the LHS of the short-circuit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108469/new/

https://reviews.llvm.org/D108469