[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

Mon Jun 27 07:53:40 PDT 2022

thieta added a comment.

Fixed the test issue. Regarding `/Fo` bit - if you want I can change it to only handle `/o` in this if statement. I don't mind either way.

================
Comment at: clang/test/Driver/ast.c:30
+// Also check clang-cl since the driver is slightly different
+// RUN: %clang_cl -ccc-print-phases -emit-ast %s 2> %t
+// RUN: echo 'END' >> %t
----------------
hans wrote:
> This needs a `--` before `%s` otherwise clang-cl might interpret the filename as a flag, e.g. if it starts with /Users which is common on Mac.
Fixed - will also fix the other tests in the same file as a NFC.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128409/new/

https://reviews.llvm.org/D128409