[PATCH] D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 26 19:42:27 PDT 2022


nridge created this revision.
nridge added reviewers: hokein, ilya-biryukov, sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman.
Herald added a project: All.
nridge requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang-tools-extra.

$0 can only be used as a tab stop, not as a placeholder (e.g.
`${0:expression}` is not valid)

Fixes https://github.com/clangd/clangd/issues/1190


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D128621

Files:
  clang-tools-extra/clangd/CodeComplete.cpp
  clang-tools-extra/clangd/CodeCompletionStrings.cpp
  clang-tools-extra/clangd/CodeCompletionStrings.h
  clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
  clang-tools-extra/clangd/unittests/CodeCompletionStringsTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128621.440099.patch
Type: text/x-patch
Size: 5676 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220627/58621a4e/attachment.bin>


More information about the cfe-commits mailing list