[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

Jun Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jun 25 21:15:38 PDT 2022


junaire marked 3 inline comments as done.
junaire added inline comments.


================
Comment at: clang/lib/Interpreter/IncrementalParser.cpp:281
 
+void IncrementalParser::Restore(PartialTranslationUnit &PTU) {
+  TranslationUnitDecl *MostRecentTU = PTU.TUPart;
----------------
v.g.vassilev wrote:
> I think we can merge this function with `Undo` where we can conditionally check if we have a llvm::Module to recover.
I'm not sure I understand you correctly, do you mean to merge `Interpreter::Restore` with `Interpreter::Undo`? I think `IncrementalParser::Restore` is used above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126682/new/

https://reviews.llvm.org/D126682



More information about the cfe-commits mailing list