[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

[Richard via Phabricator via cfe-commits]

LegalizeAdulthood added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:282
+// These are all class names in ExprCXX.h without 'CXX' prefix.
+#define CXXStmts \
+  ArrayTypeTraitExpr,\
----------------
I'm not a fan of this macro, and we're only using it once as the argument to `isa<>`; is there some problem with writing it inline?


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:246
 
+- Improved :doc:`bugprone-signal-handler
+  <clang-tidy/checks/bugprone/signal-handler>` check. Partial
----------------
Please keep the section sorted by check, so this should be inserted before `bugprone-use-after-move`


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/signal-handler.cpp:1
+// RUN: %check_clang_tidy -std=c++14 %s bugprone-signal-handler %t -- -- -isystem %S/../Inputs/Headers -isystem %S/Inputs/signal-handler
+
----------------
Prefer `-isystem %clang_tidy_headers`  instead of `-isystem %S/../Inputs/Headers`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118996/new/

https://reviews.llvm.org/D118996