[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

Sat Jun 25 08:47:32 PDT 2022

rjmccall added inline comments.

================
Comment at: clang/docs/LanguageExtensions.rst:746
 * SPIR
-* X86 (Only available under feature AVX512-FP16)
+* X86 (Enabled with feature SSE2 and up)

----------------
Could you take the wording I suggested from the other patch?  You'll need to drop the part about avoiding intermediate truncations, but it's important to still document the practical/performance difference when AVX512-FP16 is not available, even if the observable behavior is the same.

================
Comment at: clang/docs/ReleaseNotes.rst:517

+- Support for ``_Float16`` type has been added.
+
----------------

================
Comment at: clang/test/SemaCXX/Float16.cpp:4
+// RUN: %clang_cc1 -fsyntax-only -verify -triple armv7a-linux-gnu %s
+// RUN: %clang_cc1 -fsyntax-only -verify -triple aarch64-linux-gnu %s

----------------
This test (and Float16.c) should continue to have positive and negative examples even if generic x86_64 is no longer negative.  Generic i386 should still be negative, for example.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128571/new/

https://reviews.llvm.org/D128571