[PATCH] D128574: [clang-format] Quit analyzing solution space for large state count

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 24 22:22:35 PDT 2022

owenpan created this revision.
owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay.
owenpan added a project: clang-format.
Herald added a project: All.
owenpan requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Fixes https://github.com/llvm/llvm-project/issues/56043.

  rG LLVM Github Monorepo



Index: clang/lib/Format/UnwrappedLineFormatter.cpp
--- clang/lib/Format/UnwrappedLineFormatter.cpp
+++ clang/lib/Format/UnwrappedLineFormatter.cpp
@@ -1163,6 +1163,10 @@
     // While not empty, take first element and follow edges.
     while (!Queue.empty()) {
+      // Quit if we still haven't found a solution by now.
+      if (Count > 25000000)
+        return 0;
       Penalty = Queue.top().first.first;
       StateNode *Node = Queue.top().second;
       if (!Node->State.NextToken) {

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128574.439951.patch
Type: text/x-patch
Size: 566 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220625/271e324f/attachment.bin>

More information about the cfe-commits mailing list