[PATCH] D128372: [Clang-Tidy] Empty Check

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:55
+
+    auto Methods = MemberCall->getRecordDecl()->methods();
+    auto Clear = llvm::find_if(Methods, [](const CXXMethodDecl *F) {
----------------
Please don't use auto unless type is explicitly stated in same statement or iterator.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:76
+
+    auto Methods = Arg->getType()->getAsCXXRecordDecl()->methods();
+    auto Clear = llvm::find_if(Methods, [](const CXXMethodDecl *F) {
----------------
Please don't use auto unless type is explicitly stated in same statement or iterator.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.h:22
+/// For the user-facing documentation see:
+/// http://clang.llvm.org/extra/clang-tidy/checks/bugprone-standalone-empty.html
+class StandaloneEmptyCheck : public ClangTidyCheck {
----------------
Please fix URL.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.h:29
+  void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
+};
+
----------------
Please define `isLanguageVersionSupported()`.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/standalone-empty.rst:5
+=========================
+
+
----------------
Excessive newline.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/standalone-empty.rst:9
+
+The ``empty()`` method on several common ranges returns a boolean indicating
+whether or not the range is empty, but is often mistakenly interpreted as
----------------
Boolean.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128372/new/

https://reviews.llvm.org/D128372