[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 24 14:06:06 PDT 2022


Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:160
+  if (const auto *Call = dyn_cast<CallExpr>(StmtNode)) {
+    const auto *Callee = Call->getDirectCallee();
+
----------------
Please don't use `auto` when type is not spelled explicitly or iterator.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:187
+  for (const auto *GNode : SCC) {
+    const auto *CanDecl = GNode->getDecl()->getCanonicalDecl();
+
----------------
Ditto.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128401/new/

https://reviews.llvm.org/D128401



More information about the cfe-commits mailing list