[PATCH] D128519: [clang][dataflow] Move logic for creating implication and iff expressions into `DataflowAnalysisContext` from `DataflowEnvironment`.

[Stanislav Gatev via Phabricator via cfe-commits]

sgatev added inline comments.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:170
+  /// will be a value that represents the true boolean literal.
+  BoolValue &createImplication(BoolValue &LHS, BoolValue &RHS);
+
----------------
Let's call it `getOrCreateImplication` similar to the members above. Same for iff below.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:170
+  /// will be a value that represents the true boolean literal.
+  BoolValue &createImplication(BoolValue &LHS, BoolValue &RHS);
+
----------------
sgatev wrote:
> Let's call it `getOrCreateImplication` similar to the members above. Same for iff below.
Let's add tests for the new members, possibly moving existing tests from `DataflowEnvironmentTest.cpp` to `DataflowAnalysisContextTest.cpp`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128519/new/

https://reviews.llvm.org/D128519