[PATCH] D128511: [clang-tidy] Make the cert/uppercase-literal-suffix-integer fully hermetic.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 24 02:42:45 PDT 2022


hokein created this revision.
hokein added reviewers: LegalizeAdulthood, aaron.ballman.
Herald added a subscriber: xazax.hun.
Herald added a project: All.
hokein requested review of this revision.
Herald added a project: clang-tools-extra.

after the test-reorg commit (89a1d03e2b379e325daa5249411e414bbd995b5e <https://reviews.llvm.org/rG89a1d03e2b379e325daa5249411e414bbd995b5e>), the
cert/uppercase test starts to fail in our internal environment -- it accesses
a header file from "../readability", which is not a friendly to a hermetic test environment.

This change makes the test full hermetic, and does some cleanup on the
uppercase header (I think it is better to move it the share
Inputs/Header directory, and rename it)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D128511

Files:
  clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/integral_constant.h
  clang-tools-extra/test/clang-tidy/checkers/cert/uppercase-literal-suffix-integer.cpp
  clang-tools-extra/test/clang-tidy/checkers/readability/uppercase-literal-suffix-float16.cpp
  clang-tools-extra/test/clang-tidy/checkers/readability/uppercase-literal-suffix-floating-point.cpp
  clang-tools-extra/test/clang-tidy/checkers/readability/uppercase-literal-suffix-hexadecimal-floating-point.cpp
  clang-tools-extra/test/clang-tidy/checkers/readability/uppercase-literal-suffix-integer-custom-list.cpp
  clang-tools-extra/test/clang-tidy/checkers/readability/uppercase-literal-suffix-integer-ms.cpp
  clang-tools-extra/test/clang-tidy/checkers/readability/uppercase-literal-suffix-integer.cpp
  clang-tools-extra/test/clang-tidy/checkers/readability/uppercase-literal-suffix.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128511.439680.patch
Type: text/x-patch
Size: 9987 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220624/bf7737d9/attachment-0001.bin>


More information about the cfe-commits mailing list