[PATCH] D128496: [clang-format] Further improve requires clause detection

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 24 01:16:15 PDT 2022


curdeius accepted this revision.
curdeius added a comment.
This revision is now accepted and ready to land.

LGTM with Owen's suggestion.



================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3185-3188
-  default:
-    // It's an expression.
-    parseRequiresExpression(RequiresToken);
-    return false;
----------------
owenpan wrote:
> How about this instead?
> 
:+1:


================
Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:429
+  Tokens =
+      annotate("auto bar() -> Tempalte<type> requires(is_integral_v<T>) {}");
+  ASSERT_EQ(Tokens.size(), 19u) << Tokens;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128496/new/

https://reviews.llvm.org/D128496



More information about the cfe-commits mailing list