[PATCH] D128439: [Clang][WIP] Don't call distributeTypeAttrsFromDeclarator() on empty list.
Martin Böhme via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 24 01:09:17 PDT 2022
mboehme added a comment.
In D128439#3605266 <https://reviews.llvm.org/D128439#3605266>, @nikic wrote:
> Not seeing a statistically significant impact from this change: http://llvm-compile-time-tracker.com/compare.php?from=8b6f69a4da5baaf3748798a84dd16a2481b7ca7f&to=797ba50f5fd88017925fe765427b1f5f136c3310&stat=instructions Maybe it's an improvement at the 0.05% level, but it may just as well be noise. As such, I probably wouldn't bother with the change.
Thanks for performing the measurement for me!
Just a question for my understanding before I abandon the change: Shouldn't the "instructions" count be relatively resistant to noise? (I was assuming this is based on performance counters? What would cause noise in this metric?)
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits