[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical
Ishaan Gandhi via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 23 13:20:31 PDT 2022
ishaangandhi added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236
+- Fixed a false positive in :doc:`bugprone-branch-clone
+ <clang-tidy/checks/bugprone-branch-clone>` when the branches
> ishaangandhi wrote:
> > Eugene.Zelenko wrote:
> > > ishaangandhi wrote:
> > > > Eugene.Zelenko wrote:
> > > > > Eugene.Zelenko wrote:
> > > > > > ishaangandhi wrote:
> > > > > > > ishaangandhi wrote:
> > > > > > > > Eugene.Zelenko wrote:
> > > > > > > > > Documentation path was changed recently. Please also keep alphabetical order inside section.
> > > > > > > > Hm? Its still at this path on mastesr: https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/docs/ReleaseNotes.rst
> > > > > > > Also, it doesn't look alphabetized to me? Two points up is "performance-unnecessary-..." then its "bugprone-use-after...".
> > > > > > Sorry, my mistake.
> > > > > It'll be good idea to fix order of other entries too.
> > > > Happy to! Would you like that in this diff or a new one?
> > > This is trivial change and could be made in same commit.
> > Done
> Sorry for being unclear, but I meant alphabetical order for check names, not beginning of sentences.
This is then unclear to me. How do you alphabetize by check name?
CHANGES SINCE LAST ACTION
More information about the cfe-commits